-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a feature flag to disable dates tab for all courses #34511
base: master
Are you sure you want to change the base?
feat: add a feature flag to disable dates tab for all courses #34511
Conversation
Thanks for the pull request, @Cup0fCoffee! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
44940e9
to
cf0ff34
Compare
cf0ff34
to
426ca05
Compare
426ca05
to
88bb2a4
Compare
# .. toggle_use_cases: open_edx | ||
# .. toggle_creation_date: 2024-04-15 | ||
# .. toggle_tickets: https://github.com/openedx/edx-platform/pull/34511 | ||
'DISABLE_DATES_TAB': False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of an instance-wide setting, I think it makes more sense to make this configurable per course, by setting is_hideable = True in the DatesTab class, and creating a course app to configure it in case the pages and resources MFE is enabled (e.g.
def set_enabled(cls, course_key: CourseKey, enabled: bool, user: 'User') -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- I tested this: setting the feature flag hides the dates tab when it is otherwise shown
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository. - N/A
@mphilbrick211 does this require a product review as well? |
@itsjeyd same question as above? |
@farhaanbukhsh Please have a look at Does my contribution require Product Review?, it should help you with answering your question :) |
@mphilbrick211 @itsjeyd it does qualify for product review. :) |
@farhaanbukhsh Alright, thanks for checking. The next step will be for you to complete the first two items listed here to get the product review process going. |
Description
This PR adds a feature flag that allows disabling dates tab for all courses.
Testing instructions
tutor
,devstack
, etc../manage.py cms backfill_course_tabs
for them to appear, for example if running on devstack)DISABLE_DATES_TAB
flag toTrue
.Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.